feat: add methods (ilp payment method), remove references to connection #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # openapi/resource-server.yaml
🦋 Changeset detectedLatest commit: fffb846 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
# Conflicts: # openapi/resource-server.yaml
✅ Deploy Preview for openpayments-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
# Conflicts: # openapi/resource-server.yaml
mkurapov
changed the title
njlie
approved these changes
Sep 27, 2023
12 tasks
mkurapov
added a commit
that referenced
this pull request
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
This change:
methodsproperty to Incoming Payments (GET and POST responses), which contains a list of the possible payment methods that can pay into the incoming payment.ilpAddressandsharedSecretneeded to make an ILP payment between peersmethodproperty to use during Quote creation (as well as quote GET response). Only supportsilpfor now.Questions:
ilpStreamConnection, we didn't not return it for completing and listing incoming paymentsContext
Fixes #219